Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow accessing the ClientSession programmatively #30115

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Allow accessing the ClientSession programmatively #30115

merged 1 commit into from
Jan 11, 2024

Conversation

loicmathieu
Copy link
Contributor

No description provided.

@loicmathieu loicmathieu mentioned this pull request Jan 2, 2023
Open
@gsmet
Copy link
Member

gsmet commented Jan 30, 2023

@loicmathieu what's the status of this?

@gsmet gsmet added the triage/needs-feedback We are waiting for feedback. label Jan 30, 2023
@loicmathieu
Copy link
Contributor Author

@gsmet no idea, I'll have a look in the following days to try to remember why I didn't go further

@gsmet gsmet added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Feb 4, 2023
@loicmathieu loicmathieu force-pushed the mongodb-access-client-session branch from 686f2ea to cbbb97a Compare April 24, 2023 11:29
@github-actions
Copy link

github-actions bot commented Apr 24, 2023 •
edited
Loading

🎊 PR Preview 20eeab4 has been successfully built and deployed to https://quarkus-pr-main-30115-preview.surge.sh/version/main/guides/

@loicmathieu loicmathieu force-pushed the mongodb-access-client-session branch from cbbb97a to 39cc4fc Compare April 24, 2023 12:18
@loicmathieu loicmathieu marked this pull request as ready for review April 24, 2023 12:18
@loicmathieu loicmathieu removed the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Apr 24, 2023
@quarkus-bot

This comment has been minimized.

Sign in to view
@loicmathieu loicmathieu force-pushed the mongodb-access-client-session branch from 39cc4fc to 52c45bf Compare April 24, 2023 12:51
@quarkus-bot

This comment has been minimized.

Sign in to view
@loicmathieu loicmathieu requested a review from gsmet April 24, 2023 14:20
@loicmathieu
Copy link
Contributor Author

@gsmet I took the time to finish it and think it could be a nice addition for those who need more control over MongoDB transactions

@loicmathieu loicmathieu removed the triage/needs-feedback We are waiting for feedback. label May 24, 2023
@loicmathieu
Copy link
Contributor Author

@gsmet can you validate this PR? It is pretty straightforward and will give more flexibility over MongoDB transactions.

@Sanne Sanne force-pushed the mongodb-access-client-session branch from 52c45bf to a3c692c Compare October 13, 2023 08:51
@quarkus-bot

This comment has been minimized.

Sign in to view
@felixng313
Copy link

I'm looking forward to this feature.

@loicmathieu
Copy link
Contributor Author

Let's try to have a review from someone then ;)
I also rebase the PR as it's pretty old.

@felixng313
Copy link

Has the merge failed?

@geoand geoand force-pushed the mongodb-access-client-session branch from 1cb864f to 98147e5 Compare December 28, 2023 18:21
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 28, 2023
@gastaldi gastaldi force-pushed the mongodb-access-client-session branch from 98147e5 to 3637aaa Compare January 11, 2024 13:27
@gastaldi gastaldi merged commit 781060d into quarkusio:main Jan 11, 2024
23 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Jan 11, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 11, 2024
@loicmathieu loicmathieu deleted the mongodb-access-client-session branch January 17, 2024 08:39
@felixng313
Copy link

The MongoCollection only accepts com.mongodb.client.ClientSession, but the new function Panache.getSession() is returning com.mongodb.session.ClientSession. Any advice for this case?

@loicmathieu
Copy link
Contributor Author

@felixng313 this is a bug :( thanks for pointing it out.

com.mongodb.client.ClientSession extends com.mongodb.session.ClientSession so when I implement it my IDE auto-complete the wrong ClientSession interface. I'll send a bugfix soon and asl for a backport.

@loicmathieu
Copy link
Contributor Author

@felixng313 as a workaround you should be able to cast the session to com.mongodb.client.ClientSession safely.

@loicmathieu loicmathieu mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@geoand geoand geoand approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
area/documentation area/mongodb area/panache
Projects
Quarkus Documentation
Status: Done
Milestone
3.7.0.CR1
Development

Successfully merging this pull request may close these issues.
5 participants
@loicmathieu @gsmet @felixng313 @gastaldi @geoand